https://bugzilla.redhat.com/show_bug.cgi?id=1131731 Remi Collet <fedora@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxxxxxxxxxx --- Comment #1 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> --- quick notes (before review) In description: WARNING: %{_datadir}/php/Pimple.php is only provided ... Should be %{_datadir}/php/Pimple/Pimple.php (which is really provided) This compat file should probably have: include __DIR__.'/Container.php'; for project which use old version without autoloader. As discussed earlier (for guzzle), see my comment about the autoloader and PSR-0/PSR-4 order issue for local build. echo "n" | make test Cleaner to use: export NO_INTERACTION=1 make test Perhaps (need to be checked), also need export REPORT_EXIT_STATUS=1 As for twig, I think having the minimal load test "outside" the %if %{with_tests} seems better. Using "make test" (for ZTS) will imply to wait for PHP 5.5.16 push in updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review