https://bugzilla.redhat.com/show_bug.cgi?id=1118528 Remi Collet <fedora@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? --- Comment #5 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> --- Sorry but this is in the MUST list... [!]: Changelog in prescribed format. Bad date Fri Jul 29 2014: should be Tue Jul 29 2014 Simple... but blocker... Should (you can disagree ;): => I agree with making the test optional (as they are enabled by default). But I think the "minimal load test" should be always execute (so outside the %if) Obsoletes: php-twig-CTwig < %{version}-%{release} Provides: php-twig-CTwig = %{version}-%{release} => this can probably be dropped (php-twig-CTwig was never imported in Fedora) Optional dependency: Xdebug (php-pecl-xdebug) => this doesn't give any new feature, the code only check if present for some output. I think this comment can be removed => this package obsoletes all packages in the twig channel, so should also obsoletes php-channel-twig (which could then be removed from F21+ repo) Else everything is fine. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review