[Bug 1123689] Review Request: yadifa - Lightweight authoritative Name Server with DNSSEC capabilities

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1123689



--- Comment #6 from Christopher Meng <i@xxxxxxxx> ---
1. Compiler flags are still problematic, because the %optflags are inserted
before the flags defined by upstream.

Pick 1 line from the build.log:

libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I./include/dnsdb
-I./../../lib/dnscore/include -O2 -g -pipe -Wall -Werror=format-security
-Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong
--param=ssp-buffer-size=4 -grecord-gcc-switches
-specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic -g -m64
-DDNSDB_BUILD -Wall -D_FILE_OFFSET_BITS=64 -mtune=native -fno-ident -ansi
-pedantic -std=gnu99 -I/builddir/build/BUILD/yadifa-1.0.3-2880/lib/dnsdb
-I/builddir/build/BUILD/yadifa-1.0.3-2880/lib/dnsdb/include -DNDEBUG -O3 -DCMR
-c src/rr_canonize.c  -fPIC -DPIC -o .libs/rr_canonize.o
/bin/sh ./libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I.
-I./include/dnsdb   -I./../../lib/dnscore/include -O2 -g -pipe -Wall
-Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches
-specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic -g -m64
-DDNSDB_BUILD -Wall -D_FILE_OFFSET_BITS=64      -mtune=native  -fno-ident -ansi
-pedantic -std=gnu99 -I/builddir/build/BUILD/yadifa-1.0.3-2880/lib/dnsdb
-I/builddir/build/BUILD/yadifa-1.0.3-2880/lib/dnsdb/include    -DNDEBUG -O3
-DCMR 

As you can see, O3 overrides O2. And, AArch64 guys told me -mtune=native may
not work on AArch64.

You should eithor hack the makefile to change the sequence or use sed to remove
them.

2. Please add %_isa to subpkg requiring base:

https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package

3. Please bump changelog.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]