[Bug 1129889] Review Request: fig - Punctual, lightweight development environments using Docker

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1129889



--- Comment #4 from Christopher Meng <i@xxxxxxxx> ---
(In reply to Adam Miller from comment #2)
> 4) It's a dep on docker.io (docker-io package), it's x86_64-only which is
> what fig exists to orchestrate so I didn't think it made sense to have fig
> build/install on other architectures and have it not function. As Docker
> upstream adds support for other architectures we should be able to add more
> architectures.

I meant that this package should be noarch. CFLAGS are superfluous here.

And you still didn't use the correct *VERSIONED* python macros.

Requires:       python-setuptools, I'm sure it's a mistake.

%if 0%{?with_python3} should be removed from the SPEC.

Plus, bundled egg should be dropped before the build.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]