Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mapserver - Environment for building spatially-enabled internet applications https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=232792 ------- Additional Comments From cbalint@xxxxxxxxxx 2007-04-24 09:09 EST ------- (In reply to comment #2) > Created an attachment (id=153185) --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=153185&action=view) [edit] > rpmlint log for 4.10.1-2 (with gdal-config issue modified) > > Well, actually I don't know about PHP at all!! So I don't know > how to use this... > However as this is heavily related with grass, gdal.. so I will > review this. Well, this software package provedes both cgi-bin shell like interpreter and a nice php plugin, loaded and registered by apache server. Its easy we should have the .so registered in apach , thats all. this .so library exports for apache all necesary bindings, and provide a higher level programing functions in php specialized for GIS. > ------------------------------------------------------- > %{__sed} -i.libs -e 's|`\$GDAL_CONFIG --dep-libs`||' configure > ------------------------------------------------------- applied. > * License > - Well, while most files are licensed under MIT, one file is > licensed under BSD. > ------------------------------------------------------- > strptime.c > ------------------------------------------------------- erghh ... author fault, i should notify him. > Currently I do not disagree with writing "BSD" for the license > of this. > > Then after the fix above is applied.. > * rpmlint - attached. > Summary: > * Fix improper permissions. fixed all. > > Next for spec file: > A. Description entry > - Well, while there is a php releated subpackage which requires > php, does main package also require php? yes must require php, and especialy php-gd, it use some functions from php-gd > Please explain because currently I don't know how to use this > at all. well, this mapserver.so extension have some external reference to php-gd extension so its mandatory to have php-gd at all. I removed php since php-gd itself olso require php > - Do perl/python subpackage have no dependency for main package? no, its just a wrapper. > - Requires: python/Requires: perl are redundant. removed. > - Current Fedora packaging policy requires that BuildRoot includes > release number (according to the section "BuildRoot tag" of > http://fedoraproject.org/wiki/Packaging/Guidelines ) updated. > - By the way, there seems to be java/ruby binding. Would you try > to enable this? ok i try, i notice down on my TODO. > > B. Prep/Build/Install stage > - not a big problem, however fedora compilation flags is passed > twice for main and python subdirectory build (not a blocker) > - If this support parallel make, then please use. Otherwise > add some comments in spec file. ouch, i will workaround put on my TODO as non-trivial. > C. Scripts > - While no shared libraries are installed by main package, why > does main package call ldconfig? removed. > D. File entry > - README.CONFIGURE is for people who want to build this software > by themselves and so this is not needed for fedora rpm. not included for now. > - Vera related fonts under tests/ should not be installed because > these fonts are provides system-wide by bitstream-vera-fonts not included for now. > - (I say this although I know *very little* about httpd) > Please consider to move files under /var/www to %{_datadir} update my TODO for now. > Check: the section "Web Applications" of > http://fedoraproject.org/wiki/Packaging/Guidelines > - It seems that mapscript/php3/README should be added as %doc > to php subpackage. > - On my system %{_libdir}/php4/ is not owned by any package. If I own it than i break ownage for other php modules. I saw no other php modules olso own it, this is a place where all php modules go to be picked up by apache. Its owned _default_ by php-common ! > Please check if this directory is correct. > - %{perl_vendorarch}/auto/mapscript/ is not owned by any package. now its owned. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review