Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: hwbrowser https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225892 ------- Additional Comments From panemade@xxxxxxxxx 2007-04-24 08:06 EST ------- build.log showed me + desktop-file-install --vendor redhat --delete-original --dir /var/tmp/hwbrowser-0.31-1.fc7-root-mockbuild/usr/share/applications /var/tmp/hwbrowser-0.31-1.fc7-root-mockbuild/usr/share/applications/hwbrowser.desktop /var/tmp/hwbrowser-0.31-1.fc7-root-mockbuild/usr/share/applications/redhat-hwbrowser.desktop: warning: boolean key "Terminal" has value "0", boolean values should be "false" or "true", although "0" and "1" are allowed in this field for backwards compatibility /var/tmp/hwbrowser-0.31-1.fc7-root-mockbuild/usr/share/applications/redhat-hwbrowser.desktop: warning: The 'Application' category is not defined by the desktop entry specification. Please use one of "AudioVideo", "Audio", "Video", "Development", "Education", "Game", "Graphics", "Network", "Office", "Settings", "System", "Utility" instead ALSO rpmlint reported on SRPM W: hwbrowser macro-in-%changelog _datadir Macros are expanded in %changelog too, which can in unfortunate cases lead to the package not building at all, or other subtle unexpected conditions that affect the build. Even when that doesn't happen, the expansion results in possibly "rewriting history" on subsequent package revisions and generally odd entries eg. in source rpms, which is rarely wanted. Avoid use of macros in %changelog altogether, or use two '%'s to escape them, like '%%foo'. And on RPM W: hwbrowser incoherent-version-in-changelog 0.31 0.31-1.fc7 The last entry in %changelog contains a version identifier that is not coherent with the epoch:version-release tuple of the package. E: hwbrowser non-executable-script /usr/share/hwbrowser/DeviceList.py 0644 This text file contains a shebang or is located in a path dedicated for executables, but lacks the executable bits and cannot thus be executed. If the file is meant to be an executable script, add the executable bits, otherwise remove the shebang or move the file elsewhere. Kindly correct those things and update the package. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review