[Bug 1123217] Review Request: obix - ONEDC toolkit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1123217



--- Comment #4 from Michael Schwendt <bugs.michael@xxxxxxx> ---
> 4. %post libs
> -p /sbin/ldconfig
> 
> Weird.

Well, it's nearly correct. Just the second line should be appended at the end
of the first line:

  %post libs -p /sbin/ldconfig

As to answer a "Why?": The "-p" is an option that overrides the program that
shall run the scriptlet. By default, it would be /bin/sh. Here, it's
/sbin/ldconfig that will be executed with an empty scriptlet.


> %post libs
> /sbin/ldconfig

That would run /bin/sh with a shell script that executes /sbin/ldconfig. A
little bit superfluous if only running ldconfig is needed.


> %package        libs
> Summary:        Shared library files for %{name}
> Requires:       %{name}%{?_isa} = %{version}-%{release}

So, if the -libs package requires the base package, then why split off this
-libs package at all? It could not be installed independently.  The base
package also doesn't explicitly require the -libs package, so it seems you've
got the dependencies mixed up. An independent library package sort of becomes
the real "base" package your other [sub-]packages should depend on explicitly
(a reverse case of
https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package ).



> %files server

Looks like a few case of
 
https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership
and:
  https://fedoraproject.org/wiki/Packaging:UnownedDirectories

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]