https://bugzilla.redhat.com/show_bug.cgi?id=1123217 --- Comment #3 from Christopher Meng <i@xxxxxxxx> --- 1. Drop BuildRequires: glibc-devel. 2. The -doc is just a crap if only contains README.md COPYING CODING_GUIDELINES.md. Put them in the main package, and -libs, remember the way depends on your needs(e.g CODING_GUIDELINES.md is only intended for development IMO so put it into -devel), but must put license file in main package. 3. Use %cmake macro, and drop -DLIB_DIR="%{_libdir}" 4. %post libs -p /sbin/ldconfig Weird. %post libs /sbin/ldconfig 5. %if 0%{?rhel} %defattr(-, root, root) rm -rf %{buildroot} RHEL doesn't need them. 6. %attr(0755,root,root) %dir %{_sysconfdir}/obix %attr(0755,lighttpd,lighttpd) %dir %{_sharedstatedir}/obix/histories 755 is redundant. Why did you set it? 7. ln -sf %{_sharedstatedir}/obix/histories %{buildroot}/%{_sysconfdir}/obix/res/server/ Reason? 8. Better to leave the Source tag as: https://github.com/ONEDC/obix/archive/%{version}.tar.gz#/obix-%{version}.tar.gz 9. Requires: lighttpd Requires: lighttpd-fastcgi lighttpd-fastcgi depends on lighttpd, drop the explicit Requires of lighttpd. And you should append the bits macro like you've done to the other packages: Requires: lighttpd-fastcgi%{?_isa} https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package 10. -DPROJECT_DOC_DIR_SUFFIX="%{name}-doc-%{version}" F20+, use %{_pkgdocdir} We use unversioned docdir just because it can help save the bookmarks, if you keep it versioned still, after the update the bookmark will be useless. Think of it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review