https://bugzilla.redhat.com/show_bug.cgi?id=1120299 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #8 from Petr Pisar <ppisar@xxxxxxxxxx> --- Spec file changes: --- perl-Inline-Struct.spec.old 2014-08-05 14:23:55.000000000 +0200 +++ perl-Inline-Struct.spec 2014-08-05 16:10:54.000000000 +0200 @@ -17,6 +17,7 @@ BuildRequires: perl(strict) BuildRequires: perl(vars) Requires: perl(:MODULE_COMPAT_%(eval "$(perl -V:version)"; echo $version)) +Requires: perl(Parse::RecDescent) %description Inline::Struct is not a new language. It's a language extension designed to All tests pass. Ok. $ rpmlint perl-Inline-Struct.spec ../SRPMS/perl-Inline-Struct-0.06-1.fc22.src.rpm ../RPMS/noarch/perl-Inline-Struct-0.06-1.fc22.noarch.rpm perl-Inline-Struct.src: W: spelling-error %description -l en_US typemaps -> type maps, type-maps, typecast perl-Inline-Struct.noarch: W: spelling-error %description -l en_US typemaps -> type maps, type-maps, typecast 2 packages and 1 specfiles checked; 0 errors, 2 warnings. rpmlint is Ok. > FIX: Run-require `perl(Parse::RecDescent)' (Struct.pm:20). $ rpm -q --requires -p ../RPMS/noarch/perl-Inline-Struct-0.06-1.fc22.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.18.2) 1 perl(Carp) 1 perl(Data::Dumper) 1 perl(Inline) 1 perl(Inline::Struct::grammar) 1 perl(Parse::RecDescent) 1 perl(strict) 1 perl(vars) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Inline-Struct-0.06-1.fc22.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F22 (http://koji.fedoraproject.org/koji/taskinfo?taskID=7246655). Ok. Package is in line with Fedora and Perl packaging guidelines. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review