https://bugzilla.redhat.com/show_bug.cgi?id=1126100 --- Comment #11 from Tait Clarridge <tait@xxxxxxxxxxxx> --- Ran fedora-review (amazing tool by the way!) and went through as much as I could see as being an issue. I also updated my dev box to rawhide. Rpmlint ------- Checking: disco-0.5.3-1.fc22.x86_64.rpm disco-master-0.5.3-1.fc22.x86_64.rpm python-disco-0.5.3-1.fc22.x86_64.rpm disco-cli-0.5.3-1.fc22.x86_64.rpm disco-0.5.3-1.fc22.src.rpm disco.x86_64: E: no-binary disco.x86_64: W: only-non-binary-in-usr-lib disco-master.x86_64: W: no-documentation disco.src: W: invalid-url Source0: disco.tar.gz 5 packages and 0 specfiles checked; 1 errors, 3 warnings. * W: invalid-url Source0: disco.tar.gz - There is a comment in the spec file regarding this warning, disco requires the git repository to set the version for the erlang package from the gitlog. * E: no-binary - I've seen in some other erlang related packages, no-binary can be safely ignored as it is arch dependant for %{_libdir} (see bug 906473 comment 2). Also, in the Erlang guidelines it was asked that any erlang package have erlang-%{name}, but in this case I chose to leave it as disco as it is more of a standalone application and not one people would include in their own apps. I have not tested disco running on anything other than x86_64 and i686, should these arches be the only ones specified? I can try emulating arm as well and seeing if they run as expected as well. Spec URL: https://github.com/oldmantaiter/fedpkg/raw/master/disco/disco.spec SRPM URL: https://github.com/oldmantaiter/fedpkg/raw/master/disco/disco-0.5.3-1.fc22.src.rpm Koji scratch build for rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=7246422 Thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review