https://bugzilla.redhat.com/show_bug.cgi?id=1126100 José Matos <jamatos@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jamatos@xxxxxxxx --- Comment #6 from José Matos <jamatos@xxxxxxxx> --- Hi Tait, note that rpm spec files have become a lot saner with time and some of the changes reflect precisely that. An example, why should the BuildRoot be defined in the spec files? In another case (6) it all comes to the fact that soon we will change our default version of python from 2 to 3 and thus it is better to be explicit and declare what is the version really used. Before python 3 this was not an issue. In the case of the summary the convention is not to end the sentence with a dot. So there are reasons for all the changes required and the documentation is thorough, feel free to peruse it. :-) One advice it to try to build your packages using fedora-review, it is just a program and it does not replace human reasoning but it is a nice starting point. At the same time try to review other submissions to increase your fluency in rpm spec. I am a sponsor and as you can read the informal review of others request is a major point for approval. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review