https://bugzilla.redhat.com/show_bug.cgi?id=1120297 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #9 from Petr Pisar <ppisar@xxxxxxxxxx> --- Spec file changes: --- perl-Inline-Filters.spec.old 2014-07-17 16:26:37.000000000 +0200 +++ perl-Inline-Filters.spec 2014-08-05 14:44:17.000000000 +0200 @@ -14,10 +14,13 @@ BuildRequires: perl(File::Spec) BuildRequires: perl(Inline) BuildRequires: perl(Inline::C) +# Required indirectly, optional Inline dependency +BuildRequires: perl(Parse::RecDescent) BuildRequires: perl(strict) BuildRequires: perl(Test::More) BuildRequires: perl(warnings) Requires: perl(:MODULE_COMPAT_%(eval "$(perl -V:version)"; echo $version)) +Requires: perl(Parse::RecDescent) %description Inline::Filters provide common source code filters to Inline language > FIX: Tests do not pass because Inline::C optionally requires Parse::RecDescent +# Required indirectly, optional Inline dependency +BuildRequires: perl(Parse::RecDescent) Ok. All tests pass. Ok. $ rpmlint perl-Inline-Filters.spec ../SRPMS/perl-Inline-Filters-0.14-1.fc22.src.rpm ../RPMS/noarch/perl-Inline-Filters-0.14-1.fc22.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Inline-Filters-0.14-1.fc22.noarch.rpm drwxr-xr-x 2 root root 0 Aug 5 16:24 /usr/share/doc/perl-Inline-Filters -rw-r--r-- 1 root root 749 Apr 1 23:20 /usr/share/doc/perl-Inline-Filters/Changes -rw-r--r-- 1 root root 18236 Jan 6 2014 /usr/share/doc/perl-Inline-Filters/LICENSE -rw-r--r-- 1 root root 1752 Jan 6 2014 /usr/share/doc/perl-Inline-Filters/README -rw-r--r-- 1 root root 4131 Aug 5 16:24 /usr/share/man/man3/Inline::Filters.3pm.gz drwxr-xr-x 2 root root 0 Aug 5 16:24 /usr/share/perl5/vendor_perl/Inline -rw-r--r-- 1 root root 4261 Apr 1 23:15 /usr/share/perl5/vendor_perl/Inline/Filters.pm -rw-r--r-- 1 root root 5063 Mar 28 16:29 /usr/share/perl5/vendor_perl/Inline/Filters.pod File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Inline-Filters-0.14-1.fc22.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.18.2) 1 perl(Config) 1 perl(File::Spec) 1 perl(Parse::RecDescent) 1 perl(strict) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Inline-Filters-0.14-1.fc22.noarch.rpm | sort -f | uniq -c 1 perl(Inline::Filters) = 0.14 1 perl-Inline-Filters = 0.14-1.fc22 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Inline-Filters-0.14-1.fc22.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F22 (http://koji.fedoraproject.org/koji/taskinfo?taskID=7243865). Ok. Package is in line with Fedora and Perl packaging guidelines. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review