https://bugzilla.redhat.com/show_bug.cgi?id=1126100 --- Comment #4 from Christopher Meng <i@xxxxxxxx> --- 1. Drop these 2: BuildRoot: %{_tmppath}/disco-%{version}-root Vendor: Disco Authors Ref: https://fedoraproject.org/wiki/Packaging:Guidelines#Tags 2. All Group: could be dropped as well, as Fedora doesn't need them anymore. 3. Drop obsoleted stuffs: BuildRoot: %{_tmppath}/disco-%{version}-root %clean %defattr(-,root,root) 4. %{__make} -> make %{_prefix}/bin -> %{_bindir} %{_prefix}/share -> %{_datadir} == -> = %setup -n disco -> %setup -q -n disco 5. cp bin/disco bin/ddfs $RPM_BUILD_ROOT/%{_prefix}/bin Use install -pm755 to set perms instead of %attr(0755,root,root), the latter one has been abused too much. 6. DISCO_VERSION=%{version} %{__python} setup.py install -O1 --root=$RPM_BUILD_ROOT https://fedoraproject.org/wiki/Packaging:Python#Macros Please set PYTHON to %{__python2} explicitly. 7. %dir %{_prefix}/var/disco %dir %{_prefix}/lib/disco Violates FHS. 8. Add %global debug_package %{nil} to the erlang package. 9. Drop the dot: Summary: An open-source mapreduce framework. Not completed, but you should fix them. Basically, not good. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review