https://bugzilla.redhat.com/show_bug.cgi?id=975266 Lubomir Rintel <lkundrak@xxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ |needinfo?(tibbs@xxxxxxxxxxx | |) | --- Comment #10 from Lubomir Rintel <lkundrak@xxxxx> --- (In reply to Ben Rosser from comment #9) > I have gotten rid of all the documentation, as suggested. > > I've changed the version to 2012.08.14; that seems reasonable enough. I also > changed the package name to cmap-japan1-6. Thank you. > Should I retroactively update the changelog to use the right versioning? I > did, but I'm not completely confident it was the right thing to do. I don't really have a strong opinion on this and I don't believe it matters as the package was not really released. Do whatever seems fine to you. I'm finishing the review now: * Package is properly named * The version is correct * The license tag is correct * License good for Fedora * Full license text included (in each of the files) * SPEC file clean and legible * Filelist sane * Requires/provides make sense * Package owns all directories it should * Builds fine in mock * Rpmlint reasonably happy The package is APPROVED now. Please go ahead and file a SCM request: http://fedoraproject.org/wiki/Package_SCM_admin_requests -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review