Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: supervisor - System for Allowing the Control of Process State on UNIX https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=237344 toshio@xxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From toshio@xxxxxxxxxxxxxxx 2007-04-21 23:55 EST ------- 3982619435d792d333dc6ed56abdcec0 supervisor-2.1-2fc6.src.rpm Needswork: * The package will need to BuildRequire: python-devel or it won't build on FC7. NonBlocker: * The license is a bit varied. It looks like ZPL/BSD covers it but perhaps a note to see the license file would be good: License: ZPL/BSD - see LICENSE.txt * Adding -p to the install commands in the spec file will preserve timestamps and may help to prevent generation of spurious .rpmnew files when the package is upgraded. Good: * rpmlint: E: supervisor non-standard-dir-perm /var/log/supervisor 0770 The log directory can be 0770 to protect the files written to it from being read by others. /var/log/messages and /var/log/httpd are examples of this precedent. W: supervisor invalid-license ZPL/BSD W: supervisor invalid-license ZPL/BSD Zope Public License and BSD is fine. W: supervisor strange-permission supervisord.init 0755 This is an init file so 0755 is fine. * Package is named according to the package naming guidelines. * Licenses are open source and the tag matches the actual license of the code. * License file is included in the package. * Spec file is readable. * No locales. * Not a shared library. * Package owns all its files and no others. * Package uses macros consistently. * Package contains code not content. * Builds on x86_64 for FC6. * Scriptlets follow the documented standards for packages including initscripts. * Runs with the python-meld3 from Bug #237354 and a small daemon. Fix the NEEDSWORK items when you import and this is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review