Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: wqy-bitmap-fonts - a fine-tuned Chinese bitmap font https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230560 ------- Additional Comments From bbbush.yuan@xxxxxxxxx 2007-04-21 23:37 EST ------- Hi, Just FYI, we had a RPM SPEC for wqy bitmap song font at this URL: SPEC: ftp://ftp.fedora.cn/pub/fedora-cn/in-review/fonts-wenquanyi-song.spec SRPM: ftp://ftp.fedora.cn/pub/fedora-cn/in-review/fonts-wenquanyi-song-0.8.6-0.1.n20070405.fc7.src.rpm It is for nightly build, and contains a emacs setup file for FC-6 (In FC-7 it should not be used, #175599). It also contains a font alias file which I think should be useful. Here is my review: * bitmap fonts are always under "misc" directory. * I like the name fonts-wenquanyi-song-pcf and -ttf since I believe your font family will become huge in size & variants. * The font has BDF source so why not use that as Source0, and use bdftopcf to generate PCF on the fly. * Summary and %description could be localized * Requires(pre): /usr/bin/mkfontdir * Why conflicts? * Why provides? Why conflicts and provides are not match? * install -d -m755 on both %{fontdir} and %{fontconfdir} * %defattr(-, root, root, -) is nicer * %doc should not contain INSTALL* * %ghost %verify?? * Don't have to use [ -f .... ] && .... since you have already specified them in Requires * Keep old changelogs, and raise spec release number after each round of review/modification Thanks! -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review