https://bugzilla.redhat.com/show_bug.cgi?id=1111388 Mukundan Ragavan <nonamedotc@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #15 from Mukundan Ragavan <nonamedotc@xxxxxxxxx> --- (In reply to Sandro Mani from comment #14) > > Is it a legal issue to even download the tarball and then get rid of mpeg in %prep instead of manual creation of the tarball? > > See > http://fedoraproject.org/wiki/Packaging: > SourceURL#When_Upstream_uses_Prohibited_Code > I should not have asked this question based on my memory! :( > > Spec URL: http://smani.fedorapeople.org/review/gmsh.spec > SRPM URL: http://smani.fedorapeople.org/review/gmsh-2.8.4-4.fc22.src.rpm > > %changelog > * Tue Jul 22 2014 Sandro Mani <manisandro@xxxxxxxxx> - 2.8.4-4 > - Rename gmsh-demos to gmsh-doc > - Fix scriptlets for gmsh-common > - Install license file with *-libs subpackages Others are fine. I have no further issues. Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review