https://bugzilla.redhat.com/show_bug.cgi?id=1111388 --- Comment #14 from Sandro Mani <manisandro@xxxxxxxxx> --- > Is it a legal issue to even download the tarball and then get rid of mpeg in %prep instead of manual creation of the tarball? See http://fedoraproject.org/wiki/Packaging:SourceURL#When_Upstream_uses_Prohibited_Code Rpmlint: The output of the build below should be as follows: > gmsh.src: W: patch-not-applied PatchX: [...] False positive (autosetup) > gmsh.src: W: invalid-url Source0: gmsh-2.8.4-source-fedora.tar.gz As documented > gmsh.x86_64: W: no-documentation non-issue, docs are in -common which gets pulled in > gmsh.x86_64: W: no-manual-page-for-binary gmsh non-issue, manpage is in -common which gets pulled in > gmsh-common.noarch: W: desktopfile-without-binary /usr/share/applications/gmsh.desktop gmsh The desktop file is common to all gmsh executables, to which gmsh executable it points to depends on the environment (i.e. if an mpi env is loaded) > gmsh-libs.x86_64: W: unused-direct-shlib-dependency [...] Adding -Wl,--as-needed removed one of these, but not the others. Should not be a blocker though. > gmsh-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/libGmsh.so.2.8.4 exit@GLIBC_2.2.5 Needs to be considered upstream > gmsh-devel.x86_64: W: only-non-binary-in-usr-lib False positive (lib is a symlink) > gmsh-devel.x86_64: W: no-documentation License is in -libs, which is a dependency > gmsh-openmpi.x86_64: W: summary-not-capitalized C gmsh compiled against openmpi Non-issue -> Same for gmsh-openmpi* and gmsh-mpich* Spec URL: http://smani.fedorapeople.org/review/gmsh.spec SRPM URL: http://smani.fedorapeople.org/review/gmsh-2.8.4-4.fc22.src.rpm %changelog * Tue Jul 22 2014 Sandro Mani <manisandro@xxxxxxxxx> - 2.8.4-4 - Rename gmsh-demos to gmsh-doc - Fix scriptlets for gmsh-common - Install license file with *-libs subpackages -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review