Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mapserver - Environment for building spatially-enabled internet applications https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=232792 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-04-20 10:22 EST ------- Created an attachment (id=153185) --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=153185&action=view) rpmlint log for 4.10.1-2 (with gdal-config issue modified) Well, actually I don't know about PHP at all!! So I don't know how to use this... However as this is heavily related with grass, gdal.. so I will review this. For 4.10.1-2: * Mock build failure/gdal-config related issue - First of all, -2 won't be rebuilt. ------------------------------------------------------- /usr/bin/ld: cannot find -lodbcinst collect2: ld returned 1 exit status make: *** [shp2img] Error 1 error: Bad exit status from /var/tmp/rpm-tmp.41559 (%build) ------------------------------------------------------- (Well, the previous line is so long, so I will attach a full mock build log) This is because `$GDAL_CONFIG --dep-libs` in configure adds unnecessary linkages. Applying a patch for configure to remove the above seems good. For sed usage, ------------------------------------------------------- %{__sed} -i.libs -e 's|`\$GDAL_CONFIG --dep-libs`||' configure ------------------------------------------------------- * License - Well, while most files are licensed under MIT, one file is licensed under BSD. ------------------------------------------------------- strptime.c ------------------------------------------------------- Currently I do not disagree with writing "BSD" for the license of this. Then after the fix above is applied.. * rpmlint - attached. Summary: * Fix improper permissions. Next for spec file: A. Description entry - Well, while there is a php releated subpackage which requires php, does main package also require php? Please explain because currently I don't know how to use this at all. - Do perl/python subpackage have no dependency for main package? - Requires: python/Requires: perl are redundant. - Current Fedora packaging policy requires that BuildRoot includes release number (according to the section "BuildRoot tag" of http://fedoraproject.org/wiki/Packaging/Guidelines ) - By the way, there seems to be java/ruby binding. Would you try to enable this? B. Prep/Build/Install stage - not a big problem, however fedora compilation flags is passed twice for main and python subdirectory build (not a blocker) - If this support parallel make, then please use. Otherwise add some comments in spec file. C. Scripts - While no shared libraries are installed by main package, why does main package call ldconfig? D. File entry - README.CONFIGURE is for people who want to build this software by themselves and so this is not needed for fedora rpm. - Vera related fonts under tests/ should not be installed because these fonts are provides system-wide by bitstream-vera-fonts - (I say this although I know *very little* about httpd) Please consider to move files under /var/www to %{_datadir} Check: the section "Web Applications" of http://fedoraproject.org/wiki/Packaging/Guidelines - It seems that mapscript/php3/README should be added as %doc to php subpackage. - On my system %{_libdir}/php4/ is not owned by any package. Please check if this directory is correct. - %{perl_vendorarch}/auto/mapscript/ is not owned by any package. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review