https://bugzilla.redhat.com/show_bug.cgi?id=1121358 --- Comment #2 from Shawn Starr <shawn.starr@xxxxxxxxxx> --- SPEC: http://spstarr.fedorapeople.org/packages/review/xmlrpc-epi.spec SRPM: http://spstarr.fedorapeople.org/packages/review/xmlrpc-epi-0.54.2-1.fc21.src.rpm 1. SHOULD omit deprecated .spec constructs including: Group:,BuildRoot: tags %defattr lines (empty) %clean section -- FIXED 2. -devel subpkg MUST use %{?_isa} for main dep dependency, like: Requires: %{name}%{?_isa} = %{version}-%{release} -- FIXED 3. SHOULD document the need/use-of rm -r %{buildroot}%{_bindir} in %install section (preferably in a .spec comment) As far as I can tell, this is not needed, and can be removed. -- DOCUMENTED: Those are test tools, we don't need them installed 4. SHOULD drop uneccessary BuildRequires: libtool -- FIXED 5. document (or remove) this item in %build section: cp -pv [A-Z]* .. As far as I can tell, this is not needed, and can be removed. -- FIXED not needed 6. SHOULD explicitly track library soname (so bumps aren't surprising). e.g. replace %{_libdir}/libxmlrpc-epi.so.* with %{_libdir}/libxmlrpc-epi.so.0* -- FIXED now explicit -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review