[Bug 1121358] Review Request: xmlrpc-epi - An implementation of the XML-RPC protocol in C

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1121358



--- Comment #1 from Rex Dieter <rdieter@xxxxxxxxxxxx> ---
$ rpmlint xmlrpc-epi xmlrpc-epi-devel
xmlrpc-epi-devel.x86_64: W: only-non-binary-in-usr-lib
xmlrpc-epi-devel.x86_64: W: no-documentation
2 packages and 0 specfiles checked; 0 errors, 2 warnings.

Naming: ok

License: ok

Sources: ok
081e605491429cda17c5f021f211b8fd  xmlrpc-epi-0.54.2.tar.bz2

scriptlets: ok


1.  SHOULD omit deprecated .spec constructs including:
Group:,BuildRoot: tags
%defattr lines
(empty) %clean section

2.  -devel subpkg MUST use %{?_isa} for main dep dependency, like:
Requires: %{name}%{?_isa} = %{version}-%{release}

3. SHOULD document the need/use-of
rm -r %{buildroot}%{_bindir}
in %install section (preferably in a .spec comment)
As far as I can tell, this is not needed, and can be removed.

4.  SHOULD drop uneccessary 
BuildRequires: libtool

5.  document (or remove) this item in %build section:
cp -pv [A-Z]* ..
As far as I can tell, this is not needed, and can be removed.

6.  SHOULD explicitly track library soname (so bumps aren't surprising). e.g.
replace
%{_libdir}/libxmlrpc-epi.so.*
with
%{_libdir}/libxmlrpc-epi.so.0*

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]