[Bug 1115700] Review Request: nodejs-open - Open a file or url in the user's preferred application

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1115700

Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |panemade@xxxxxxxxx
              Flags|                            |fedora-review?



--- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Review:

+ mock build is successful for f22

- rpmlint output on rpms gave
nodejs-open.src: W: spelling-error Summary(en_US) url -> URL, curl, purl
nodejs-open.src: W: spelling-error %description -l en_US url -> URL, curl, purl
nodejs-open.x86_64: W: spelling-error Summary(en_US) url -> URL, curl, purl
nodejs-open.x86_64: W: spelling-error %description -l en_US url -> URL, curl,
purl
nodejs-open.x86_64: E: no-binary
nodejs-open.x86_64: W: only-non-binary-in-usr-lib
nodejs-open.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/nodejs-open/LICENSE
nodejs-open-debuginfo.x86_64: E: empty-debuginfo-package
3 packages and 0 specfiles checked; 2 errors, 6 warnings.

==> See suggestion below

+ Source verified with upstream as (sha256sum)
srpm tarball    
:f5e85c2037b9355b7acbdc7459030027555bf08b01cb6d4db6712655dd39060a
upstream tarball
:f5e85c2037b9355b7acbdc7459030027555bf08b01cb6d4db6712655dd39060a

+ License "MIT" is valid and is included in its own file as %doc

+ rest looks following packaging guidelines



suggestions:
1) Add following to spec
BuildArch:  noarch

%if 0%{?fedora} >= 19
ExclusiveArch:  %{nodejs_arches} noarch
%else
ExclusiveArch:  %{ix86} x86_64 %{arm} noarch
%endif

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]