[Bug 1115664] Review Request: nodejs-connect-livereload - Connect middleware for adding the livereload script to the response

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1115664

Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |panemade@xxxxxxxxx
              Flags|                            |fedora-review?



--- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Review:

+ mock build is successful for f22

- rpmlint output on rpms gave
nodejs-connect-livereload.src: W: spelling-error Summary(en_US) middleware ->
middle ware, middle-ware, middleweight
nodejs-connect-livereload.src: W: spelling-error %description -l en_US
middleware -> middle ware, middle-ware, middleweight
nodejs-connect-livereload.x86_64: W: spelling-error Summary(en_US) middleware
-> middle ware, middle-ware, middleweight
nodejs-connect-livereload.x86_64: W: spelling-error %description -l en_US
middleware -> middle ware, middle-ware, middleweight
nodejs-connect-livereload.x86_64: E: no-binary
nodejs-connect-livereload.x86_64: W: only-non-binary-in-usr-lib
nodejs-connect-livereload-debuginfo.x86_64: E: empty-debuginfo-package
3 packages and 0 specfiles checked; 2 errors, 5 warnings.

==> See suggestion below

+ Source verified with upstream as (sha256sum)
srpm tarball    
:426ab32f280dd90281a8ba996ebe176fc5025838828b2ef4d35f6ea6e765411b
upstream tarball
:426ab32f280dd90281a8ba996ebe176fc5025838828b2ef4d35f6ea6e765411b

+ License "MIT" is valid and is included in its own file as %doc

+ rest looks following packaging guidelines


Suggestions:
1) Add following to spec
BuildArch:  noarch

%if 0%{?fedora} >= 19
ExclusiveArch:  %{nodejs_arches} noarch
%else
ExclusiveArch:  %{ix86} x86_64 %{arm} noarch
%endif

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]