[Bug 1115661] Review Request: nodejs-base64-js - Base64 encoding/decoding in pure JS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1115661

Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |panemade@xxxxxxxxx
              Flags|                            |fedora-review?



--- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Review:

+ mock build is successful for f22

- rpmlint output on rpms gave
nodejs-base64-js.src: W: invalid-url URL:
https://www.npmjs.org/package/base64-js <urlopen error [Errno -2] Name or
service not known>
nodejs-base64-js.src: W: invalid-url Source0:
http://registry.npmjs.org/base64-js/-/base64-js-0.0.7.tgz <urlopen error [Errno
-2] Name or service not known>
nodejs-base64-js.x86_64: W: invalid-url URL:
https://www.npmjs.org/package/base64-js <urlopen error [Errno -2] Name or
service not known>
nodejs-base64-js.x86_64: E: no-binary
nodejs-base64-js.x86_64: W: only-non-binary-in-usr-lib
nodejs-base64-js-debuginfo.x86_64: W: invalid-url URL:
https://www.npmjs.org/package/base64-js <urlopen error [Errno -2] Name or
service not known>
nodejs-base64-js-debuginfo.x86_64: E: empty-debuginfo-package
3 packages and 0 specfiles checked; 2 errors, 5 warnings.
==> See suggestion below

+ Source verified with upstream as (sha256sum)
srpm tarball    
:dc7c93b9932956dffa33960b55d2d5b3692864f0d1121a940cfe5d11a4bdf76c
upstream tarball
:dc7c93b9932956dffa33960b55d2d5b3692864f0d1121a940cfe5d11a4bdf76c

+ License "MIT" is valid 

- License is NOT packaged as %doc.

+ rest looks following packaging guidelines


Suggestions:
1) Good to add some description instead just package name
2) Add LICENSE.MIT to %doc

3) Add following to spec
BuildArch:  noarch

%if 0%{?fedora} >= 19
ExclusiveArch:  %{nodejs_arches} noarch
%else
ExclusiveArch:  %{ix86} x86_64 %{arm} noarch
%endif

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]