[Bug 1115709] Review Request: nodejs-w3cjs - A node.js module for using the w3c validator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1115709

Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |panemade@xxxxxxxxx
              Flags|                            |fedora-review?



--- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Review:

+ mock build is successful for f22

- rpmlint output on rpms gave
nodejs-w3cjs.src: W: spelling-error Summary(en_US) js -> dis, ks, j
nodejs-w3cjs.src: W: spelling-error Summary(en_US) validator -> lavatorial
nodejs-w3cjs.src: W: spelling-error %description -l en_US js -> dis, ks, j
nodejs-w3cjs.src: W: spelling-error %description -l en_US url's -> curl's,
purl's, hurl's
nodejs-w3cjs.src: W: spelling-error %description -l en_US html -> HTML, ht ml,
ht-ml
nodejs-w3cjs.src: W: spelling-error %description -l en_US validator ->
lavatorial
nodejs-w3cjs.x86_64: W: spelling-error Summary(en_US) js -> dis, ks, j
nodejs-w3cjs.x86_64: W: spelling-error Summary(en_US) validator -> lavatorial
nodejs-w3cjs.x86_64: W: spelling-error %description -l en_US js -> dis, ks, j
nodejs-w3cjs.x86_64: W: spelling-error %description -l en_US url's -> curl's,
purl's, hurl's
nodejs-w3cjs.x86_64: W: spelling-error %description -l en_US html -> HTML, ht
ml, ht-ml
nodejs-w3cjs.x86_64: W: spelling-error %description -l en_US validator ->
lavatorial
nodejs-w3cjs.x86_64: E: no-binary
nodejs-w3cjs.x86_64: W: only-non-binary-in-usr-lib
nodejs-w3cjs.x86_64: W: dangling-symlink
/usr/lib/node_modules/w3cjs/node_modules/argparse
/usr/lib/node_modules/argparse
nodejs-w3cjs.x86_64: W: dangling-symlink
/usr/lib/node_modules/w3cjs/node_modules/superagent
/usr/lib/node_modules/superagent
nodejs-w3cjs-debuginfo.x86_64: E: empty-debuginfo-package
3 packages and 0 specfiles checked; 2 errors, 15 warnings.

==> See suggestion below

+ Source verified with upstream as (sha256sum)
srpm tarball    
:172553bbbc2f1ce5c24d46a926f311de9d8058eddc7f716b8da046fc4a6193e2
upstream tarball
:172553bbbc2f1ce5c24d46a926f311de9d8058eddc7f716b8da046fc4a6193e2

+ License "Public Domain" is valid and is included in its own file as %doc.


+ rest looks following packaging guidelines


Suggestions:
1) Update to latest upstream 0.1.25

2) Add following to spec
BuildArch:  noarch

%if 0%{?fedora} >= 19
ExclusiveArch:  %{nodejs_arches} noarch
%else
ExclusiveArch:  %{ix86} x86_64 %{arm} noarch
%endif

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]