[Bug 1115707] Review Request: nodejs-vow-queue - Vow-based task queue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1115707

Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |panemade@xxxxxxxxx
              Flags|                            |fedora-review?



--- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Review:

+ mock build is successful for f22

- rpmlint output on rpms gave
nodejs-vow-queue.x86_64: E: no-binary
nodejs-vow-queue.x86_64: W: only-non-binary-in-usr-lib
nodejs-vow-queue.x86_64: W: dangling-symlink
/usr/lib/node_modules/vow-queue/node_modules/vow /usr/lib/node_modules/vow
nodejs-vow-queue-debuginfo.x86_64: E: empty-debuginfo-package
3 packages and 0 specfiles checked; 2 errors, 2 warnings.

==> See below suggestion for debuginfo

+ Source verified with upstream as (sha256sum)
srpm tarball    
:2104d077ef9b98a7f532c7174d931d34c33ad6c33e08858e164891e7cca189cd
upstream tarball
:2104d077ef9b98a7f532c7174d931d34c33ad6c33e08858e164891e7cca189cd

- License tag is not complete.

suggestions:
1) As per source file License is dual. That is license tag should be "MIT and
GPLv3+". Also, please clarify upstream this and ask them to provide which GPL
version they really intend this code.

2) Add following to spec
BuildArch:  noarch

%if 0%{?fedora} >= 19
ExclusiveArch:  %{nodejs_arches} noarch
%else
ExclusiveArch:  %{ix86} x86_64 %{arm} noarch
%endif

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]