[Bug 1115667] Review Request: nodejs-gonzales-pe - Gonzales Preprocessor Edition (fast CSS parser)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1115667



--- Comment #3 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Review:

+ mock build is successful for f22

- rpmlint output on rpms gave
nodejs-gonzales-pe.src: W: spelling-error %description -l en_US preprocessors
-> processors, predecessors, microprocessor
nodejs-gonzales-pe.x86_64: W: spelling-error %description -l en_US
preprocessors -> processors, predecessors, microprocessor
nodejs-gonzales-pe.x86_64: E: no-binary
nodejs-gonzales-pe.x86_64: W: only-non-binary-in-usr-lib
nodejs-gonzales-pe-debuginfo.x86_64: E: empty-debuginfo-package
3 packages and 0 specfiles checked; 2 errors, 3 warnings.

==> See below suggestions

+ Source verified with upstream as (sha256sum)
srpm tarball    
:4b6bd26612b5dd221696f9a638ed6a8af950c98664400fe3e41b6c040928cf47
upstream tarball
:4b6bd26612b5dd221696f9a638ed6a8af950c98664400fe3e41b6c040928cf47

+ License "MIT" is valid 

- License file is not packaged.

+ rest looks following packaging guidelines


Suggestions:
1) Add following to spec
BuildArch:  noarch

%if 0%{?fedora} >= 19
ExclusiveArch:  %{nodejs_arches} noarch
%else
ExclusiveArch:  %{ix86} x86_64 %{arm} noarch
%endif

2) Add doc directory files and MIT-LICENSE.txt as %doc


Please provide updated package

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]