https://bugzilla.redhat.com/show_bug.cgi?id=1119197 --- Comment #6 from Chen Chen <aflyhorse@xxxxxxxxxxx> --- (In reply to Christopher Meng from comment #5) > (In reply to Chen Chen from comment #4) > > Because I seperated my patch from the original git snapshot. > > You should use a released tarball from the official website, then rebase > your patch. No comments around there, I don't know where you got the sources. > > Your source0 contains no URL and as a result it's untrusted. Please use the > full link. I don't think use the released tarball is a good idea: a) It doesn't talk to modern xboard, but use an outdated xshogi as GUI. xshogi is a years old folk of xboard. b) The tarball also needs "autoreconf" on f20. The autotoolchain in tarball is too old and doesn't honor "make install DESTDIR=" I've updated the spec and added source in comments according to https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Using_Revision_Control > Also your patch only invokes the check of the texinfo and it doesn't make > sense to me that such a horrendous list of BRs should be pulled in, it's > wrong. Please read carefully: > > https://fedoraproject.org/wiki/Packaging:Guidelines#Exceptions_2 Thanks for the link. I've eliminated them in my 3rd submission in attachment. > And your name also caught my eyes as well, just a note to ensure that please > use your real name here if possible in most cases. This is my real name. I can email you a photocopy of my passport if you want. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review