[Bug 1119197] Review Request: gnushogi - Shogi (Japanese Chess) AI engine

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1119197



--- Comment #5 from Christopher Meng <i@xxxxxxxx> ---
(In reply to Chen Chen from comment #4)
> Because I seperated my patch from the original git snapshot.

You should use a released tarball from the official website, then rebase your
patch. No comments around there, I don't know where you got the sources.

Your source0 contains no URL and as a result it's untrusted. Please use the
full link.

> My patch involved tweaking the configure.ac, thus cause a full "autoreconf"
> in %prep stage and pulled in a long list of build dependency. The build
> dependency list is generated via auto-buildrequires
> (https://apps.fedoraproject.org/packages/auto-buildrequires)

That tool is a crap nowadays, and that long list generated is also a crap. You
need to know what gnushogi needs for the building, not let tool teach you how
to find the dependencies. Don't be sloppy.

Also your patch only invokes the check of the texinfo and it doesn't make sense
to me that such a horrendous list of BRs should be pulled in, it's wrong.
Please read carefully:

https://fedoraproject.org/wiki/Packaging:Guidelines#Exceptions_2

> Koji Build output:
> http://koji.fedoraproject.org/koji/taskinfo?taskID=7142190
> http://koji.fedoraproject.org/koji/taskinfo?taskID=7142198

Successful build indicates nothing as the package you sent here doesn't match
the guideline.

And your name also caught my eyes as well, just a note to ensure that please
use your real name here if possible in most cases.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]