https://bugzilla.redhat.com/show_bug.cgi?id=1115049 --- Comment #4 from Dominic Cleal <dcleal@xxxxxxxxxx> --- (In reply to Florian "der-flo" Lehner from comment #3) > (In reply to Dominic Cleal from comment #2) > > > [ ] Please add (#1115049) to the inital comment in the spec-file > > > > Done, wasn't exactly sure what style this should have, let me know if it > > should be different. > > [ ] Instead of > - Initial version > It should be > - Initial version (#1115049) > There is no written rule to do so. But it makes it much easier to go back > and find the inital ticket later. Ah sorry, I misunderstood. Fixed. > [ ] Now you missed to increment the release field for the changes to and > write a short comment about what have changed. Some kind of: > > * Tue Jul 08 2014 Dominic Cleal <dcleal@xxxxxxxxxx> 0.3.5-2 > - Added LICENSE, NOTES and README.md to files-section > - Added initial tickernumber to initial comment > > * Tue Jul 01 2014 Dominic Cleal <dcleal@xxxxxxxxxx> 0.3.5-1 > - Initial version (#1115049) Fixed, incremented to -3. Is it good practice to import this -3 into Fedora git, or reset it to -1? (If/when we get there.) > [ ] Instead of > mkdir -p %{buildroot}%{_pkgdocdir} > cp -a LICENSE NOTES README.md %{buildroot}%{_pkgdocdir} > It should be > %doc LICENSE NOTES README.md > After %files Fixed. > [ ] I'm not quite happy about: > mv %{buildroot}%{_sysconfdir}/%{name}.conf{.example,} > I miss the whitespace between the source and the destination. Or am I wrong? It's a shell shortcut, it expands to two arguments, i.e. mv %{buildroot}%{_sysconfdir}/%{name}.conf.example %{buildroot}%{_sysconfdir}/%{name}.conf > Using install -p would be better, too. The .example config file has already been installed in the buildroot by the Makefile, rather than copying it from the source. Since I'll manage this via %config in the RPM, I want to remove the .example extension. Good hint about install -p though, I've replaced "cp -a" for the documentation with "install". Spec URL: http://domcleal.fedorapeople.org/reviews/freight/freight.spec SRPM URL: http://domcleal.fedorapeople.org/reviews/freight/freight-0.3.5-3.fc20.src.rpm Thanks Florian. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review