https://bugzilla.redhat.com/show_bug.cgi?id=825409 --- Comment #41 from Michael Schwendt <bugs.michael@xxxxxxx> --- > %package playerplugin > Summary: Player plugin for %{name} > Requires: %{name}%{?_isa} = %{version}-%{release} > Requires: %{name}-media = %{version}-%{release} The %name base package already depends on %name-media. > BuildRequires: player-devel > > %description playerplugin > Player plugin driver for %{name} > %files playerplugin > %{_libdir}/player/libgazebo_player.so > %{_datadir}/%{name}-%{abiversion}/examples/player So, it is a plugin for Player and therefore should be named player-gazebo to meet the %parent-%child naming guidelines: https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Addon_Packages_.28General.29 > %package ode The base %name package depends on libgazebo_ode automatically, so putting it in a subpackage is questionable: $ rpm -qp gazebo-ode-3.0.0-3.fc20.x86_64.rpm --provides|grep ^lib libgazebo_ode.so.3()(64bit) $ rpm -qpR gazebo-3.0.0-3.fc20.x86_64.rpm |grep _ode libgazebo_ode.so.3()(64bit) libgazebo_physics_ode.so.3()(64bit) > %package media A better choice would have been to introduce a -filesystem or -common package for some of the directories included in this -media package (e.g. the empty examples directory). Currently, even the -devel package needs those directories, and the -media package is 30+ MB! Splitting off a -libs subpackage from the base package would have been a good idea, too. The -devel package doesn't need to depend on plugins and media, does it? Similarly for the Player plugin. Currently it pulls in everything. gazebo pkgconfig file tells: Libs: -L${libdir} -L${prefix}/lib64/gazebo-3.0/plugins -L -lgazebo_transport -lgazebo_physics -lgazebo_sensors -lgazebo_rendering -lgazebo_gui -lsdformat -lgazebo_msgs -lgazebo_math -lgazebo_common -lgazebo CFlags: -I${includedir}/gazebo-3.0 -I/usr/include/sdformat-2.0 Why the empty -L? Why is it adding the plugins path to the linker's search path list? Linking with any of the plugins won't work, because they are stored outside runtime linker's search path. The gazebo-config.cmake file even adjusts the rpath for the plugins dir? What's the story here? > -rw-r--r-- /usr/share/gazebo-3.0/setup.sh > -rw-r--r-- /usr/share/gazebo/setup.sh The same file in two places. It puts the plugins directory into LD_LIBRARY_PATH. > %package doc > Summary: Development documentation for %{name} > Requires: %{name} = %{version}-%{release} The PDF and HTML files in this package do not need a dependency on the base package. -- You are receiving this mail because: You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review