Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ruby-bsearch - Binary search library for Ruby https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=236492 ------- Additional Comments From dev@xxxxxxxxxx 2007-04-15 05:55 EST ------- Sorry, one more mistake: [build@ip-50 SPECS]$ rpm -qlp ../RPMS/noarch/ruby-bsearch-1.5-1.noarch.rpm /usr/lib/ruby/site_ruby/1.8/bsearch.rb /usr/share/doc/ruby-bsearch-1.5 /usr/share/doc/ruby-bsearch-1.5/ChangeLog /usr/share/doc/ruby-bsearch-1.5/bsearch.en.rd /usr/share/doc/ruby-bsearch-1.5/bsearch.ja.rd /usr/share/doc/ruby-bsearch-1.5/bsearch.png [build@ip-50 SPECS]$ grep License ruby-bsearch.spec License: GPL >From ReviewGuidelines: SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. Also, according to bsearch.rb, it is licensed under ruby's license, which looking at /usr/share/doc/ruby-1.8.5.35/COPYING is GPL plus a custom one. Might be better to reference as Ruby(GPL)? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review