https://bugzilla.redhat.com/show_bug.cgi?id=1101521 --- Comment #13 from Lubomir Rintel <lkundrak@xxxxx> --- (In reply to Ralf Corsepius from comment #12) > (In reply to Lubomir Rintel from comment #10) > > Seems reasonably good to me now. I see that you've added the format-security > > patch; which is great. > > I am quite concerned about the source code's quality. To me it looks like a > ca. 10 years pld student's work, which has never been adjusted to modern > Linux demands nor seen actual keep-alive maintainance since then == Low > quality and unsafe code. Well, it's not exactly a secret that as far as it goes for academic/scientific software, code quality is often not vast and authors tend not to keep up with toolchain developments (I just updated siril today...). That said, this is solemnly packager's responsibility. If he's able to cope with the issues (and it seems to me he is) and the package serves its purpose (would it be submitted for the review if it didn't?) it's good to go. > Openly said, I would not have approved this package because of the code > quality. Thanks for sharing your attitude, but this would be just you making up guidelines. I'm positive that if someone challenged your decision given the relevance of your reasoning it would be overturned. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review