https://bugzilla.redhat.com/show_bug.cgi?id=1101521 --- Comment #12 from Ralf Corsepius <rc040203@xxxxxxxxxx> --- (In reply to Lubomir Rintel from comment #10) > Seems reasonably good to me now. I see that you've added the format-security > patch; which is great. I am quite concerned about the source code's quality. To me it looks like a ca. 10 years pld student's work, which has never been adjusted to modern Linux demands nor seen actual keep-alive maintainance since then == Low quality and unsafe code. Openly said, I would not have approved this package because of the code quality. > I'm a bit concerned about amount of stuff done in %prep. I understand it's > not very easy to get rid of those, but you still might want to open a ticket > upstream (to fix their encodings & FSF address, etc.). You can simply ignore these FSF address warnings. Addressing these are upstream busyness, but otherwise are of not of any importance to Fedora. The fact rpmlint is complaining about these is an rpmlint sillyness. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review