https://bugzilla.redhat.com/show_bug.cgi?id=1063040 --- Comment #18 from Mo Morsi <mmorsi@xxxxxxxxxx> --- (In reply to Ken Dreyer from comment #17) > With the latest Ruby guidelines for Fedora 21, you will not need to > explicitly declare Requires or Provides for your gem. Please use dist tags > to wrap the Requires and Provides, like so: > > %if 0%{?fc19} || 0%{?fc20} > Requires: ruby(release) > Requires: rubygems > Requires: rubygem(eventmachine) >= 1.0.0.beta.4 > %endif > Am a little confused as to whether ruby(release) should or should not be included, brought up the issue on the ruby sig mailing list: https://lists.fedoraproject.org/pipermail/ruby-sig/2014-May/001588.html > As a separate issue, please mark the %{gem_instdir}/README.md file as > "%doc", since it is documentation, not code. (that one's confusing since > it's already in a -doc subpackage...) It was my understanding that files in the 'doc' subpackage didn't need to be marked as %doc (since that is the whole intent of the subpackage). I could be wrong on this, and know that it is ok to mark doc subpkg files as %doc, so am fine either way. > > Please make these changes and I'll approve the package and sponsor you (with > the caveat that mmorsi will be your main mentor and responsible for your > actions in Fedora going forward). > Thanks Ken, yes I am fine w/ this. Nitesh I just ask that if you are unsure about something, just ask me before committing / building. Most likely after a while this will be unnecessary but at the beginning there are many gotcha's/edge cases. Thanks again for the new package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review