https://bugzilla.redhat.com/show_bug.cgi?id=1063040 --- Comment #17 from Ken Dreyer <ktdreyer@xxxxxxxxxxxx> --- Hi Nitesh, please accept my apologies for taking so long to get back on this review. The package looks good. With the latest Ruby guidelines for Fedora 21, you will not need to explicitly declare Requires or Provides for your gem. Please use dist tags to wrap the Requires and Provides, like so: %if 0%{?fc19} || 0%{?fc20} Requires: ruby(release) Requires: rubygems Requires: rubygem(eventmachine) >= 1.0.0.beta.4 %endif and %if 0%{?fc19} || 0%{?fc20} Provides: rubygem(%{gem_name}) = %{version} %endif When Fedora 19 goes end-of-life, you can remove the "0%{?fc19}" part, and when Fedora 20 goes end-of-life, you can remove the whole Requires and Provides sections entirely. See https://fedoraproject.org/wiki/Packaging:DistTag for more information about dist tags. As a separate issue, please mark the %{gem_instdir}/README.md file as "%doc", since it is documentation, not code. (that one's confusing since it's already in a -doc subpackage...) Please make these changes and I'll approve the package and sponsor you (with the caveat that mmorsi will be your main mentor and responsible for your actions in Fedora going forward). Full fedora-review output follows. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. See above note about wrappingn Requires and Provides in a dist tag. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Ruby: [x]: Platform dependent files must all go under %{gem_extdir_mri}, platform independent under %{gem_dir}. [x]: Gem package must not define a non-gem subpackage [x]: Macro %{gem_extdir} is deprecated. [x]: Gem package is named rubygem-%{gem_name} [x]: Package contains BuildRequires: rubygems-devel. [x]: Gem package must define %{gem_name} macro. [x]: Pure Ruby package must be built as noarch [x]: Package does not contain Requires: ruby(abi). [x]: Package contains Requires: ruby(release). ===== SHOULD items ===== Generic: [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Avoid bundling fonts in non-fonts packages. [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. This is ok - packager has provided explanation in comments. [x]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. Ruby: [!]: Test suite of the library should be run. This is ok - packager has provided explanation in comments. [x]: Specfile should use macros from rubygem-devel package. [x]: Gem package should exclude cached Gem. [x]: Gem should use %gem_install macro. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: rubygem-em-socksify-0.3.0-7.fc21.noarch.rpm rubygem-em-socksify-doc-0.3.0-7.fc21.noarch.rpm rubygem-em-socksify-0.3.0-7.fc21.src.rpm rubygem-em-socksify.noarch: E: useless-provides rubygem(em-socksify) 3 packages and 0 specfiles checked; 1 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint rubygem-em-socksify-doc rubygem-em-socksify rubygem-em-socksify.noarch: E: useless-provides rubygem(em-socksify) 2 packages and 0 specfiles checked; 1 errors, 0 warnings. Requires -------- rubygem-em-socksify-doc (rpmlib, GLIBC filtered): rubygem-em-socksify rubygem-em-socksify (rpmlib, GLIBC filtered): ruby(release) ruby(rubygems) rubygem(eventmachine) rubygems Provides -------- rubygem-em-socksify-doc: rubygem-em-socksify-doc rubygem-em-socksify: rubygem(em-socksify) rubygem-em-socksify Source checksums ---------------- https://rubygems.org/gems/em-socksify-0.3.0.gem : CHECKSUM(SHA256) this package : 2a9feb13e65efc89434008e99dda9d80e11f9aa1a294dda60a2c400134896b89 CHECKSUM(SHA256) upstream package : 2a9feb13e65efc89434008e99dda9d80e11f9aa1a294dda60a2c400134896b89 Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -b 1063040 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Ruby, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review