[Bug 1101016] Review Request: takari-local-repository - Takari :: Local Repository

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1101016



--- Comment #8 from Gerard Ryan <gerard@xxxxxxx> ---
(In reply to gil cattaneo from comment #5)
> should be obsolete tesla-concurrent-localrepo ... ?

I'm not 100% sure that it needs to in this case, does it? I'm not so familiar
with package renaming. I can't think of any situation where these would clash,
and I'll be retiring/blocking tesla-concurrent-localrepo once this is available
in the repos. Actually obseleting tesla-concurrent-localrepo could cause
issues, since this doesn't provide the same artifact, or classes on the same
namespace. Does that make sense, or should I still obselete?

(In reply to gil cattaneo from comment #7)
> Please, open a bug for include license file to upstream

That has been open as a github PR since the last package review.

> 
> [!]: %check is present and all tests pass.
> Please, can you add a comment which explain why testing is disabled?

Tests are disabled because of newer aether api in Fedora than these tests
expect. I'll add the comment before importing.

Thanks a lot for your reviews this evening gil! I'll see if I can find some
time to do some for you this week, or soon at least! :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]