https://bugzilla.redhat.com/show_bug.cgi?id=1099473 Jeff Schroeder <jeffschroeder@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jeffschroeder@xxxxxxxxxxxx --- Comment #1 from Jeff Schroeder <jeffschroeder@xxxxxxxxxxxx> --- Note that I'm not an official package reviewer yet, so this is only to help a real reviewer. Questions / Suggestions ======================= 1. This is a django reusable app, shouldn't it "Require: Django"? 2. In %install, you remove the egg-info directory, but it is still in the package: [jeff@omniscience SPECS] (master)$ rpm -qlp ../RPMS/python-django-angular-0.7.1-1.fc20.noarch.rpm | grep \.egg-info /usr/lib/python2.7/site-packages/django_angular-0.7.1-py2.7.egg-info /usr/lib/python2.7/site-packages/django_angular-0.7.1-py2.7.egg-info/PKG-INFO /usr/lib/python2.7/site-packages/django_angular-0.7.1-py2.7.egg-info/SOURCES.txt /usr/lib/python2.7/site-packages/django_angular-0.7.1-py2.7.egg-info/dependency_links.txt /usr/lib/python2.7/site-packages/django_angular-0.7.1-py2.7.egg-info/requires.txt /usr/lib/python2.7/site-packages/django_angular-0.7.1-py2.7.egg-info/top_level.txt Also, fedora packaging python policy is explicit on keeping the egg-info directory: http://fedoraproject.org/wiki/Packaging:Python#Files_to_include You then include it explicitly in %files, why? RPMlint output ============== Looks good to me [jeff@omniscience SPECS] (master)$ rpmlint python-django-angular.spec ../SRPMS/python-django-angular-0.7.1-1.fc20.src.rpm ../RPMS/python-django-angular-0.7.1-1.fc20.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. Other than those 2 small things, this looks good to me. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review