[Bug 1100899] Review Request: ratools - Framework for IPv6 Router Advertisements

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1100899

Igor Gnatenko <i.gnatenko.brain@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |i.gnatenko.brain@xxxxxxxxx



--- Comment #1 from Igor Gnatenko <i.gnatenko.brain@xxxxxxxxx> ---
> %{_sysconfdir}/bash_completion.d/

should be:

> %{_sysconfdir}/bash_completion.d/*

because you shouldn't own this dir. only some files in it.


>License:		Apache License, Version 2.0

should be:

>License:		ASL 2.0

Reference: https://fedoraproject.org/wiki/Licensing:Main#Good_Licenses


%build section has no %configure. That's bad. if there no configure file - use
this hook:

%prep
...
echo '#!/bin/sh' > ./configure
chmod +x ./configure

%build
%configure
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]