https://bugzilla.redhat.com/show_bug.cgi?id=1100961 Kalev Lember <kalevlember@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kalevlember@xxxxxxxxx --- Comment #4 from Kalev Lember <kalevlember@xxxxxxxxx> --- I have a few drive-by comments: > %setup -q -n %{name}-%{version} Could just say '%setup -q' because %{name}-%{version} is the default for -n. > %cmake CMakeLists.txt It should be '%cmake .' -- the convention is to pass the directory name to cmake instead of the CMakeLists.txt file. > # Update icon cache > /usr/bin/gtk-update-icon-cache %{_datadir}/pixmaps &>/dev/null || : Please drop the icon cache scriptlets. These aren't meant for the pixbuf directory but only for the themable directories (e.g. /usr/share/icons/hicolor). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review