https://bugzilla.redhat.com/show_bug.cgi?id=1099269 --- Comment #2 from Shawn Iwinski <shawn.iwinski@xxxxxxxxx> --- (In reply to Parag AN(पराग) from comment #1) > Suggestions: > 1) Group tag is not necessary in Fedora now and can be removed from spec > file. See https://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag Drupal 7 packaging guidelines template (https://fedoraproject.org/wiki/Packaging:Drupal7#Module) has the Group tag. Per overall packaging guidelines (https://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag) it can stay to be compatible with EPEL and all Drupal pkgs are packaged for EPEL. > 2) Buildroot tag is not needed. See > https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag This is an EPEL5 item that needs to be removed unless planning to package for EPEL5 -- and in that case there are several other things missing. I would suggest not packaging for EPEL5 unless you need it so drop the buildroot. > 3) File upstream bug/ticket to correct the FSF address in LICENSE.txt No upstream bug/ticket necessary because it will automatically get fixed on next upstream release by the Drupal buildbot that automatically adds the LICENSE.txt file -- the upstream module owner has no control over the LICENSE.txt file added. Additional items: 4) "Requires: php(language) >= 4.1" not required and should not be present. You do need to run phpcompatinfo on the module though -- see https://fedoraproject.org/wiki/Packaging:Drupal7#PHP_Extensions 5) This is a module, not a theme, so "%{module}" not "%{theme}" -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review