[Bug 1087812] Review Request: gpaw - A grid-based real-space PAW method DFT code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1087812



--- Comment #21 from Susi Lehtola <susi.lehtola@xxxxxx> ---
Are you sure gpaw doesn't need scipy to run?

**

I believe hdf5 (and its MPI flavors) should be added as BuildRequirements, so
that gpaw gets built support for these.

**

If you can, you should modify the upstream setup.py so that the libraries are
always installed as 755. It's standard for *nix shared libraries.

**

Actually,
MUST: Each package must consistently use macros.

is not OK. You are mixing %{buildroot} (1 occurrence) and %{optflags} (2
occurrences) vs $RPM_BUILD_ROOT (4 occurrences) and $RPM_OPT_FLAGS (0
occurrences).

http://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS

To fix this, replace the 3 occurrences of $RPM_BUILD_ROOT with %{buildroot}. If
you like, you can also replace %{buildroot} and %{optflags} with
$RPM_BUILD_ROOT and $RPM_OPT_FLAGS.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]