https://bugzilla.redhat.com/show_bug.cgi?id=1095662 --- Comment #3 from Petr Šabata <psabata@xxxxxxxxxx> --- (In reply to David Dick from comment #2) > (In reply to Petr Šabata from comment #1) > > Missing BRs: > > perl(Config) > > perl(ExtUtils::MM_Unix) > > Done. Check. > > Your package always run-requires Parse::DMIDecode; you want to remove line > > 41. > > *ouch* Done. Check. > > Are the explicit run-requires in the virtdetect package necessary? > > It was the only way i knew to remove the requires for Getopt::Long, POSIX, > etc from perl-Sys-Detect-Virtualization (where they are not required) and > keep them in virtdetect (where they are). Suggestions? You don't need to remove them at all; they're not there :) Just drop the req filters in the main package and explicit run requires in the virtdetect one. It will work like a charm. The dependencies (and provides) are put in the packages according to what files they include. > > It might not be obvious to the user that virtdetect is a subpackage of this > > one; maybe packaging the README in its own %doc would be a good idea? > > Okay. Along the same sort of line, i thought including the Changelog would > be useful too? Could be but I find it somewhat less important; the README points the user to the main package which is installed and provides the Changelog already. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review