https://bugzilla.redhat.com/show_bug.cgi?id=1038167 Pavel Raiskup <praiskup@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rdieter@xxxxxxxxxxxx Flags| |needinfo?(rdieter@xxxxxxxx. | |edu) --- Comment #5 from Pavel Raiskup <praiskup@xxxxxxxxxx> --- Several issues in first iteration --------------------------------- * seems like new upstream url appeared in the meantime https://github.com/ivmai/libatomic_ops/ * new recent version 7.4.2 https://github.com/ivmai/libatomic_ops/wiki/Download better URL tag should be used, commented Source0 should be removed (existing macros inside), cnucnu checker already prepared * licensing > (In reply to Michael Schwendt from comment #3) > That would not affect the License tag of this package, though. Unless > upstream may want everything to be GPLv2 instead of GPLv2+. The license of libatomic_ops_gpl.a is GPLv2, IIRC (as Michael wrote), thus we should probably ship as GPLv2 and MIT and we should document in spec file why (license breakdown). * the testsuite result for ppc64le should be also ignored (#1096574) * rpmlint issues should be fixed, see (filtered from FP) list below * dynamic libraries: > (In reply to Michael Schwendt from comment #3) > That's a tough one. This setting overrides the default. I've tried to find > a comment on whether the devs think the interface is ready for a shared > lib (which is at version 1:3:0 -> 1.0.3 currently). Several packages at > Fedora BuildRequires the -static one so far. I would go with packaging shared libraries, git log shows that the dynamic libraries are expected (addition of -version-info, e.g.). But still, we'll need to make libatomic_ops_gpl dependant on libatomic_ops (reported upstream), (link error "undefined reference to `AO_pause'" with -latomic_ops_gpl). I also asked to turn dynamic libraries on by default. * note: package was deprecated, this is actually "re-review" * note: upgrade path is OK ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [!]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. Note: The underscore in name is upstream decision. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 81920 bytes in 9 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [-]: Sources used to build the package match the upstream source, as provided in the spec URL. Note: new upstream release. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: Static libraries in -static or -devel subpackage, providing -devel if present. Note: Package has .a files: libatomic_ops-static. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Sources can be downloaded from URI in Source: tag Note: Could not download Source0: http://www.hpl.hp.com/personal/Hans_Boehm/gc/gc_source/libatomic_ops-7.4.0.tar.gz See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [-]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: transitively *-static ~> *-devel ~> base [x]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [-]: SourceX tarball generation or download is documented. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. Note: Known problems of stack feature on ppc*. [-]: Packages should try to preserve timestamps of original installed files. Note: direct "make install". [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: The placement of pkgconfig(.pc) files are correct. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint /trimmed from spelling false positives/ ------- Checking: libatomic_ops-7.4.0-1.fc20.x86_64.rpm libatomic_ops-devel-7.4.0-1.fc20.x86_64.rpm libatomic_ops-static-7.4.0-1.fc20.x86_64.rpm libatomic_ops-7.4.0-1.fc20.src.rpm libatomic_ops.x86_64: W: spurious-executable-perm /usr/share/doc/libatomic_ops/README.md libatomic_ops.x86_64: W: spurious-executable-perm /usr/share/doc/libatomic_ops/ChangeLog libatomic_ops.x86_64: W: spurious-executable-perm /usr/share/doc/libatomic_ops/COPYING libatomic_ops.x86_64: E: incorrect-fsf-address /usr/share/doc/libatomic_ops/COPYING libatomic_ops.x86_64: W: spurious-executable-perm /usr/share/doc/libatomic_ops/AUTHORS libatomic_ops.x86_64: W: spurious-executable-perm /usr/share/doc/libatomic_ops/LICENSING.txt libatomic_ops-devel.x86_64: W: spurious-executable-perm /usr/share/doc/libatomic_ops-devel/README_malloc.txt libatomic_ops-devel.x86_64: W: spurious-executable-perm /usr/share/doc/libatomic_ops-devel/README_win32.txt libatomic_ops-devel.x86_64: W: spurious-executable-perm /usr/share/doc/libatomic_ops-devel/README.txt libatomic_ops-devel.x86_64: W: spurious-executable-perm /usr/share/doc/libatomic_ops-devel/README_stack.txt libatomic_ops-static.x86_64: W: no-documentation libatomic_ops.src:10: W: macro-in-comment %{name} libatomic_ops.src:10: W: macro-in-comment %{version} libatomic_ops.src: W: invalid-url Source0: http://www.hpl.hp.com/personal/Hans_Boehm/gc/gc_source/libatomic_ops-7.4.0.tar.gz HTTP Error 404: Not Found 4 packages and 0 specfiles checked; 1 errors, 17 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint libatomic_ops-static libatomic_ops-devel libatomic_ops libatomic_ops-static.x86_64: W: no-documentation libatomic_ops-devel.x86_64: W: spurious-executable-perm /usr/share/doc/libatomic_ops-devel/README_malloc.txt libatomic_ops-devel.x86_64: W: spurious-executable-perm /usr/share/doc/libatomic_ops-devel/README_win32.txt libatomic_ops-devel.x86_64: W: spurious-executable-perm /usr/share/doc/libatomic_ops-devel/README.txt libatomic_ops-devel.x86_64: W: spurious-executable-perm /usr/share/doc/libatomic_ops-devel/README_stack.txt libatomic_ops.x86_64: W: undefined-non-weak-symbol /usr/lib64/libatomic_ops_gpl.so.1.0.3 AO_pause libatomic_ops.x86_64: W: spurious-executable-perm /usr/share/doc/libatomic_ops/README.md libatomic_ops.x86_64: W: spurious-executable-perm /usr/share/doc/libatomic_ops/ChangeLog libatomic_ops.x86_64: W: spurious-executable-perm /usr/share/doc/libatomic_ops/COPYING libatomic_ops.x86_64: E: incorrect-fsf-address /usr/share/doc/libatomic_ops/COPYING libatomic_ops.x86_64: W: spurious-executable-perm /usr/share/doc/libatomic_ops/AUTHORS libatomic_ops.x86_64: W: spurious-executable-perm /usr/share/doc/libatomic_ops/LICENSING.txt 3 packages and 0 specfiles checked; 1 errors, 15 warnings. # echo 'rpmlint-done:' Requires -------- libatomic_ops-static (rpmlib, GLIBC filtered): libatomic_ops-devel(x86-64) libatomic_ops-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libatomic_ops(x86-64) libatomic_ops.so.1()(64bit) libatomic_ops_gpl.so.1()(64bit) libatomic_ops (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) rtld(GNU_HASH) Provides -------- libatomic_ops-static: libatomic_ops-static libatomic_ops-static(x86-64) libatomic_ops-devel: libatomic_ops-devel libatomic_ops-devel(x86-64) pkgconfig(atomic_ops) libatomic_ops: libatomic_ops libatomic_ops(x86-64) libatomic_ops.so.1()(64bit) libatomic_ops_gpl.so.1()(64bit) Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -b 1038167 Buildroot used: fedora-20-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review