[Bug 1080583] Review Request: compat-qpid-cpp - Compatibility modules for Qpid

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1080583



--- Comment #15 from Darryl L. Pierce <dpierce@xxxxxxxxxx> ---
(In reply to Mukundan Ragavan from comment #13)
> To go through the remaining issues, 
> 
> 
> - Development (unversioned) .so files in -devel subpackage, if present.
>   Note: Unversioned so-files directly in %_libdir.
>   See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages

Fixed

> - ldconfig called in %post and %postun if required.
>   Note: /sbin/ldconfig not called in compat-qpid-cpp-server
>   See: http://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries
> 
> Related rpmlint error - 
> 
> compat-qpid-cpp-server.x86_64: E: postin-without-ldconfig
> /usr/lib64/libqpidbroker.so.2.0.0

Fixed.

> [?]: Spec use %global instead of %define unless justified.
>      Note: %define requiring justification: %{!?python_sitearch: %define
>      python_sitearch %(%{__python} -c "from distutils.sysconfig import
>      get_python_lib; print get_python_lib(1)")}
> 
> Why %define here?

That was missed when others were replaced. I've fixed it now.

> 
> compat-qpid-cpp.src: E: specfile-error -e:1:in `<main>': Use RbConfig
> instead of obsolete and deprecated Config.
> compat-qpid-cpp.src: E: specfile-error -e:1:in `<main>': Use RbConfig
> instead of obsolete and deprecated Config.
> compat-qpid-cpp.src: E: specfile-error -e:1:in `<main>': Use RbConfig
> instead of obsolete and deprecated Config.
> compat-qpid-cpp.src: E: specfile-error -e:1:in `<main>': Use RbConfig
> instead of obsolete and deprecated Config.

Fixed.

Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6843052
Updated spec:  http://mcpierce.fedorapeople.org/rpms/compat-qpid-cpp.spec
Updated SRPM: 
http://mcpierce.fedorapeople.org/rpms/compat-qpid-cpp-0.24-6.fc20.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]