[Bug 1091144] Review Request: perl-Parse-DMIDecode - Interface to SMBIOS using dmidecode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1091144



--- Comment #7 from David Dick <ddick@xxxxxxxx> ---
(In reply to Paul Howarth from comment #5)
> perl(Cwd) and perl(File::Spec) are only needed by Makefile.PL, which you
> don't
> use, so there's no need to BuildRequire them.

Fair.  Removed.

> perl(Config) is not needed if AUTOMATED_TESTING is set at build time, which
> it is.

Done.

> perl(constant) is only used in the example code, so is not needed for the
> build.

Done.

> Build.PL asks for Test::Deep but it's not actually used.

And done.

> No blockers here. APPROVED.

Thanks for the review Paul.  Most appreciated.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]