https://bugzilla.redhat.com/show_bug.cgi?id=1091144 --- Comment #6 from David Dick <ddick@xxxxxxxx> --- (In reply to Paul Howarth from comment #4) > A few quick comments before I go through the review checklist: > > The POD problem for EL-6 is > https://rt.cpan.org/Public/Bug/Display.html?id=52296; the patch > https://rt.cpan.org/Ticket/Attachment/699959/360879/fix-pod-urls.patch > attached to that ticket fixes the issue and doesn't break other builds, so I > think that would be a better fix than skipping the test on EL-6. Agreed. Thanks for this. Applied. > Please add a spec comment about why setting %debug_package to %{nil} is > desired (I know, but not everybody would get it). Done. > Use of macros for commands like %{__rm} is discouraged in the guidelines. Okay. Removed. > Also, be aware that Nicola (upstream) hasn't updated any of her CPAN > packages since January 2008, so if there's any bugs that need fixing, you're > probably on your own. I know this as current maintainer of perl-RRD-Simple... Thanks for the warning. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review