https://bugzilla.redhat.com/show_bug.cgi?id=1091770 --- Comment #7 from Michael Schwendt <bugs.michael@xxxxxxx> --- A brief look: > Name: ctlib > Group: Development/Libraries The Group tag for library base package has been "System Environment/Libraries" for many years. Alternatively, drop it since it's optional nowadays. https://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag > License: GPLv3+ Any comment on fedora-review licensecheck.txt output? > %description It's not a full sentence yet. > %package devel > Summary: Computational Topology Library Headers > Group: Development/Libraries > Requires: %{name} = %{version}-%{release} Probably the spec file has not been updated yet, because the base package dependency is not arch-specific yet. > %package docs > Summary: Computational Topology Documentation package > Group: Development/Libraries If at all, it's "Group: Documentation". Plus, the guidelines suggest -doc not -docs as the subpackage name: https://fedoraproject.org/wiki/Packaging:Guidelines#Documentation Currently this subpackage is only 6K small. How much documentation will there be? > Requires: %{name} = %{version}-%{release} Please re-review this dependency. If the documentation can be displayed with any doc file browser (e.g. PDF, HTML, TXT), a dependency on the base package is not needed and only makes it more difficult to install this without having to install dependencies. > %description docs > Documentation in HTML format for CTL. > %package examples > Summary: Source examples for CTL > Requires: %{name} = %{version}-%{release} Questionable dep here. Compiling the examples would need the ctlib-devel package currently. https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package > make %{?_smp_mflags} CFLAGS="%{optflags}" The build output is non-verbose, however. In the build.log one cannot verify what preprocessor and compiler options are used during build. > %files > %doc %{_mandir}/man1/* Files in %_mandir are marked as %doc implicitly. See "rpm -E %__docdir_path". This package does not include the license file. Notice: https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Subpackage_Licensing > %files devel > %{_includedir}/* > %doc %{_docdir}/LICENSE Same as above for %_docdir. The license could be moved to the base package. > %files examples > %doc %{_docdir}/examples/* Same as above for %_docdir. Directory /usr/share/doc/examples is not included yet. https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership https://fedoraproject.org/wiki/Packaging:UnownedDirectories -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review