[Bug 1094057] Review Request: libes - Managing an entity system in C++

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1094057

Michael Schwendt <bugs.michael@xxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |177841 (FE-NEEDSPONSOR)



--- Comment #3 from Michael Schwendt <bugs.michael@xxxxxxx> ---
* https://fedoraproject.org/wiki/Package_Review_Process#Contributor

* https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group

* Please enter your full name in the bugzilla account preferences.

* Consider running "fedora-review -b 1094057" to point that tool at this ticket
for many helpful checks.


> %package        doc
> Summary:        Documentation files for %{name}
> Requires:       %{name}%{?_isa} = %{version}-%{release}

Is that -doc subpackage really arch-specific? It contains HTML documentation.
"BuildArch: noarch" sounds plausible.

For reading the HTML documentation one does not need to install the base
library package. Please don't add such a dependency to _independent_ -doc
packages. If the documentation can only be displayed with a program in the base
package, that would be an example of a case when to add such a dep.

In case you added the dep only for the license and directories included in the
base package, consider duplicating the license file and dirs in the -doc
package instead.


> %files
> %{_libdir}/*.so
> %dir %{_defaultdocdir}/es
> %doc %{_defaultdocdir}/es/COPYING

Uh, that's odd.

If the package is named "libes", it ought to store doc files in a directory
named "libes" not "es".

Btw, in spec files you can use %_docdir just fine, and files below
/usr/share/doc are marked as %doc implicitly (see "rpm -E %__docdir_path").


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]