[Bug 613001] Review Request: Heimdal - Alternative Kerberos implementation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=613001

Orion Poplawski <orion@xxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |orion@xxxxxxxxxxxxx
              Flags|                            |fedora-review?



--- Comment #58 from Orion Poplawski <orion@xxxxxxxxxxxxx> ---
I'm still getting sporadic test failures building on my machine, but other
builds seem fine, so I'm going to hope for the best.

Issues:
=======
- Permissions on files are set properly.
  Note: See rpmlint output
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions
- Texinfo files are installed using install-info in %post and %preun if
  package has .info files.
  Note: Texinfo .info file(s) in heimdal-libs
  See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Texinfo
- Static libraries in -static or -devel subpackage, providing -devel if
  present.
  Note: Package has .a files: heimdal-devel. Does not provide -static:
  heimdal-devel.
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries
- Package does not contain any libtool archives (.la)
  Note: heimdal-libs : /usr/lib64/heimdal/libasn1.la heimdal-libs :
  /usr/lib64/heimdal/libgssapi.la heimdal-libs : /usr/lib64/heimdal/libhdb.la
  heimdal-libs : /usr/lib64/heimdal/libheimbase.la heimdal-libs :
  /usr/lib64/heimdal/libheimntlm.la heimdal-libs :
  /usr/lib64/heimdal/libhx509.la heimdal-libs :
  /usr/lib64/heimdal/libkadm5clnt.la heimdal-libs :
  /usr/lib64/heimdal/libkadm5srv.la heimdal-libs :
  /usr/lib64/heimdal/libkafs.la heimdal-libs : /usr/lib64/heimdal/libkdc.la
  heimdal-libs : /usr/lib64/heimdal/libkrb5.la heimdal-libs :
  /usr/lib64/heimdal/libotp.la heimdal-libs : /usr/lib64/heimdal/libroken.la
  heimdal-libs : /usr/lib64/heimdal/libsl.la heimdal-libs :
  /usr/lib64/heimdal/libwind.la heimdal-libs : /usr/lib64/heimdal/windc.la
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries
- Drop %defattr()

Rpmlint
-------
heimdal-workstation.x86_64: E: missing-call-to-setgroups /usr/libexec/kfd
heimdal-workstation.x86_64: E: missing-call-to-setgroups /usr/libexec/popper
heimdal-workstation.x86_64: W: manual-page-warning
/usr/share/man/man8/heimdal-kadmin.8.gz 119: warning: macro `Q1' not defined
heimdal-appl-clients.x86_64: W: dangling-symlink /etc/login.access
/etc/security/access.conf
heimdal-appl-clients.x86_64: E: invalid-locale-man-dir
/usr/share/man/heimdal/man5/login.access.5.gz
heimdal-appl-servers.x86_64: E: invalid-locale-man-dir
/usr/share/man/heimdal/man5/ftpusers.5.gz
heimdal-server.x86_64: E: non-standard-dir-perm /var/log/heimdal 0700L
heimdal-server.x86_64: E: non-readable /etc/heimdal-kadmind.acl 0600L
heimdal-server.x86_64: E: zero-length /etc/heimdal-kadmind.acl
heimdal-server.x86_64: E: incoherent-logrotate-file /etc/logrotate.d/heimdal
heimdal-server.x86_64: W: non-conffile-in-etc /etc/logrotate.d/heimdal
heimdal-server.x86_64: E: non-readable /etc/heimdal-slaves 0600L
heimdal-server.x86_64: E: zero-length /etc/heimdal-slaves
heimdal-server.x86_64: E: non-readable /etc/heimdal-kdc.conf 0600L
heimdal-server.x86_64: E: non-standard-dir-perm /var/heimdal 0700L
heimdal-server.x86_64: W: non-standard-dir-in-var heimdal
heimdal-libs.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/heimdal/libasn1.so
heimdal-libs.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/heimdal/libkrb5.so
heimdal-libs.x86_64: E: postin-without-install-info
/usr/share/info/hx509.info.gz
heimdal-libs.x86_64: E: postin-without-install-info
/usr/share/info/hx509.info.gz
heimdal-libs.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/heimdal/libkdc.so
heimdal-libs.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/heimdal/libkafs.so
heimdal-libs.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/heimdal/libheimntlm.so
heimdal-libs.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/heimdal/libhdb.so
heimdal-libs.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/heimdal/libroken.so
heimdal-libs.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/heimdal/libsl.so
heimdal-libs.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/heimdal/libotp.so
heimdal-libs.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/heimdal/libgssapi.so
heimdal-libs.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/heimdal/libhx509.so
heimdal-libs.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/heimdal/libkadm5clnt.so
heimdal-libs.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/heimdal/libheimbase.so
heimdal-libs.x86_64: E: postin-without-install-info
/usr/share/info/heimdal.info.gz
heimdal-libs.x86_64: E: postin-without-install-info
/usr/share/info/heimdal.info.gz
heimdal-libs.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/heimdal/libwind.so
heimdal-libs.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/heimdal/libkadm5srv.so
heimdal-devel.x86_64: W: manual-page-warning
/usr/share/man/man3/krb5_get_creds_opt_set_impersonate.3.gz 136: warning: macro
`Fi' not defined
heimdal-devel.x86_64: W: manual-page-warning
/usr/share/man/man3/krb5_get_creds_opt_set_ticket.3.gz 136: warning: macro `Fi'
not defined
heimdal-devel.x86_64: W: manual-page-warning
/usr/share/man/man3/krb5_get_creds.3.gz 136: warning: macro `Fi' not defined
heimdal-devel.x86_64: W: manual-page-warning
/usr/share/man/man3/krb5_get_creds_opt_alloc.3.gz 136: warning: macro `Fi' not
defined
heimdal-devel.x86_64: W: manual-page-warning
/usr/share/man/man3/krb5_get_creds_opt_set_options.3.gz 136: warning: macro
`Fi' not defined
heimdal-devel.x86_64: W: manual-page-warning
/usr/share/man/man3/krb5_get_creds_opt_free.3.gz 136: warning: macro `Fi' not
defined
heimdal-devel.x86_64: W: manual-page-warning /usr/share/man/man3/gssapi.3.gz
451: cannot use character `2' as a starting delimiter
heimdal-devel.x86_64: W: manual-page-warning /usr/share/man/man3/gssapi.3.gz
451: cannot use character `8' as a starting delimiter
heimdal-devel.x86_64: W: manual-page-warning /usr/share/man/man3/gssapi.3.gz
451: cannot use character `4' as a starting delimiter
heimdal-devel.x86_64: W: manual-page-warning /usr/share/man/man3/gssapi.3.gz
451: cannot use character `8' as a starting delimiter
heimdal-devel.x86_64: W: manual-page-warning /usr/share/man/man3/gssapi.3.gz
451: cannot use character `1' as a starting delimiter
heimdal-devel.x86_64: W: manual-page-warning /usr/share/man/man3/gssapi.3.gz
451: cannot use character `0' as a starting delimiter
heimdal-devel.x86_64: W: manual-page-warning /usr/share/man/man3/gssapi.3.gz
451: cannot use character `0' as a starting delimiter
heimdal-devel.x86_64: W: manual-page-warning /usr/share/man/man3/gssapi.3.gz
451: cannot use character `0' as a starting delimiter
heimdal-devel.x86_64: W: manual-page-warning /usr/share/man/man3/gssapi.3.gz
451: cannot use character `0' as a starting delimiter
heimdal-devel.x86_64: W: manual-page-warning
/usr/share/man/man3/krb5_get_creds_opt_set_enctype.3.gz 136: warning: macro
`Fi' not defined
heimdal-devel.x86_64: W: manual-page-warning
/usr/share/man/man3/krb5_get_creds_opt_add_options.3.gz 136: warning: macro
`Fi' not defined
heimdal-path.x86_64: E: explicit-lib-dependency heimdal-libs
heimdal-path.x86_64: E: executable-sourced-script /etc/profile.d/heimdal.sh
0755L
heimdal-path.x86_64: E: executable-sourced-script /etc/profile.d/heimdal.csh
0755L
heimdal.src: W: strange-permission heimdal-generate-autoconf-tarball 0775L
heimdal.src: W: strange-permission heimdal-ipropd-slave-wrapper 0775L

AutoTools: Obsoleted m4s found
------------------------------
  AC_PROG_LIBTOOL found in: heimdal-
  d60ba47157db86f1996e055a41caf1a9a96e2afe/configure.ac:17, heimdal-
  d60ba47157db86f1996e055a41caf1a9a96e2afe/lib/libedit/configure.ac:21

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]